Skip to content

Conversation

bhouston
Copy link
Member

Description

This PR addresses two related configuration improvements:

  1. Renames config variables for simplicity:

    • modelProviderprovider
    • modelNamemodel
  2. Adds warnings instead of errors when users try to set non-existent config variables.

Implementation Details

Variable Renaming

  • Added new variables while keeping old ones for backward compatibility
  • Updated tests to work with both old and new variable names
  • Added deprecation notices in the options documentation

Non-existent Config Variables

  • Modified the config set command to warn rather than error when attempting to set an unknown config key
  • Still displays the list of valid keys to guide users
  • Allows the operation to proceed, which is useful for experimental features

Testing

  • All tests have been updated and are passing
  • Backward compatibility is maintained

Resolves #159
Resolves #160

- Rename modelProvider to provider and modelName to model for simplicity
- Keep old variable names for backward compatibility
- Add warning instead of error when setting non-existent config variables
- Update tests to reflect these changes

Resolves #159
Resolves #160
@bhouston bhouston merged commit cda1a4d into main Mar 10, 2025
2 checks passed
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version mycoder-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bhouston bhouston deleted the config-improvements branch March 12, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add warning for non-existent config variables Rename config variables for simplicity

1 participant